Rusty Russell 01bce4e7b7 askrene: don't crash if asked to route 0 msat. ...

But don't allow it either.

```
Jan 19 13:18:52 boltz lightningd[2259911]: cln-askrene: plugins/askrene/algorithm.c:274: simple_feasibleflow: Assertion `amount > 0' failed.
Jan 19 13:18:52 boltz lightningd[2259911]: cln-askrene: FATAL SIGNAL 6 (version v24.11.1-1-ge9dbdeb)
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e212b407 send_backtrace
Jan 19 13:18:52 boltz lightningd[2259911]:         common/daemon.c:33
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e212b49e crashdump
Jan 19 13:18:52 boltz lightningd[2259911]:         common/daemon.c:75
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba9251f ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964bae69fc ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba92475 ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba787f2 ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba7871a ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba89e95 ???
Jan 19 13:18:52 boltz lightningd[2259911]:         ???:0
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e211695e simple_feasibleflow
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/algorithm.c:274
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e2111495 minflow
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/mcf.c:1014
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e210bc74 get_routes
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/askrene.c:414
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e210c610 do_getroutes
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/askrene.c:615
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e210cad8 listpeerchannels_done
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/askrene.c:741
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e211b35a handle_rpc_reply
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/libplugin.c:1084
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e211b54c rpc_read_response_one
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/libplugin.c:1388
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e211b5fd rpc_conn_read_response
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/libplugin.c:1412
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e214fe8f next_plan
Jan 19 13:18:52 boltz lightningd[2259911]:         ccan/ccan/io/io.c:60
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e215036e do_plan
Jan 19 13:18:52 boltz lightningd[2259911]:         ccan/ccan/io/io.c:422
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e215042b io_ready
Jan 19 13:18:52 boltz lightningd[2259911]:         ccan/ccan/io/io.c:439
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e2151e2e io_loop
Jan 19 13:18:52 boltz lightningd[2259911]:         ccan/ccan/io/poll.c:455
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e211cc29 plugin_main
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/libplugin.c:2488
Jan 19 13:18:52 boltz lightningd[2259911]: 0x5576e210cb38 main
Jan 19 13:18:52 boltz lightningd[2259911]:         plugins/askrene/askrene.c:1262
Jan 19 13:18:52 boltz lightningd[2259911]: 0x7f964ba79d8f ???
```

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON-RPC: `getroutes` will refuse, not crash, if asked to find a route fr 0msat.

2025-01-28 10:53:22 +10:30

..

data

tests: Reckless test fix for project must contain name

2025-01-09 11:15:05 +01:00

fuzz

splice: Update splice signature msg type

2024-11-21 14:15:36 +10:30

plugins

ccan/htable: update to explicit DUPS/NODUPS types.

2025-01-21 09:18:25 +10:30

vectors

…

autogenerate-rpc-examples.py

tests: Add logger config with fixture

2025-01-24 17:00:03 +10:30

benchmark.py

…

conftest.py

pytest: use --developer instead of environment variable.

2023-09-21 20:08:24 +09:30

fixtures.py

lightningd: add option to crash itself after some time.

2025-01-27 11:07:04 +10:30

rkls_github_canned_server.py

…

test_askrene.py

askrene: don't crash if asked to route 0 msat.

2025-01-28 10:53:22 +10:30

test_bookkeeper.py

pytest: don't set experimental-offers in tests: it's the default now.

2024-11-18 10:42:54 +01:00

test_cln_rs.py

lightningd: deprecate decodepay.

2024-11-17 14:21:23 +10:30

test_clnrest.py

tests: adjust cln-grpc tests for new default start

2024-11-12 09:43:54 +10:30

test_closing.py

pytest: fix flake in test_onchain_slow_anchor.

2025-01-27 11:07:04 +10:30

test_connection.py

pytest: fix race in test_reconnect_remote_sends_no_sigs

2025-01-27 11:07:04 +10:30

test_db.py

pytest: adapt tests to avoid deprecated APIs in close (tx and txid).

2024-11-17 16:04:06 +10:30

test_gossip.py

pytest: make test_gossip_throttle more reliable.

2025-01-27 11:07:04 +10:30

test_invoices.py

lightningd: deprecate decodepay.

2024-11-17 14:21:23 +10:30

test_misc.py

pytest: fix flake in test_restorefrompeer.

2024-12-20 15:36:07 +10:30

test_mkfunding.py

…

test_onion.py

…

test_opening.py

pytest: mark test_rbf_reconnect_tx_construct flaky:

2025-01-27 11:07:04 +10:30

test_pay.py

lightningd: populate listsendpays destination from injectpaymentonion if we can.

2024-12-17 08:14:45 +10:30

test_plugin.py

pytest: fix race in test_autoclean.

2024-11-19 17:51:18 +10:30

test_reckless.py

test: Fixed test plugin source paths for reckless

2024-11-19 09:06:28 +10:30

test_renepay.py

renepay: add test for description interface

2024-11-06 09:59:27 +01:00

test_restart.py

splice: tx_abort no longer reestablishes

2024-11-21 14:15:36 +10:30

test_runes.py

pytest: don't set experimental-offers in tests: it's the default now.

2024-11-18 10:42:54 +01:00

test_splice.py

bkpr: add bookkeeping assertions to splice in + out tests

2024-11-17 14:25:29 +10:30

test_splicing_disconnect.py

pytest: fix test_splice_disconnect_commit

2025-01-27 11:07:04 +10:30

test_splicing_insane.py

splice: Allow splice_update to return signatures

2024-11-12 06:42:52 +10:30

test_splicing.py

splice: tx_abort no longer reestablishes

2024-11-21 14:15:36 +10:30

test_wallet.py

pytest: fix hsmtool which reports leak under address sanitizer.

2024-11-17 14:09:10 +10:30

test_xpay.py

pytest: mark xpay real gossip test as slow

2025-01-27 11:07:04 +10:30

utils.py

tests: Add testnet4 default port

2025-01-13 15:45:19 -08:00

valgrind-suppressions.txt

…