davide/pallectrum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
15,247 Commits 3 Branches 0 Tags
89936689fbae99bdf75a9b76bf3c19abf622f878
Commit Graph

5451 Commits

Author SHA1 Message Date
Sander van Grieken
89936689fb qml: fix imports, flake issues 2022-11-14 12:19:56 +01:00
Sander van Grieken
97254bb0ed qml: remove ready signal hack, wizard_data now available at WizardComponent construction time 2022-11-14 12:19:56 +01:00
Sander van Grieken
3c903d8fd7 qml: allow wizard pages to supply title suffix 2022-11-14 12:19:56 +01:00
Sander van Grieken
428ba209f4 qml: multisig wizard; cosigner w. electrum seed 2022-11-14 12:19:56 +01:00
Sander van Grieken
5246f3d510 qml: refactor is_last checks to mostly lambdas, add multisig flow for 1st cosigner keystore, 
add initial flow and view placeholders for additional cosigners.
 2022-11-14 12:19:56 +01:00
Sander van Grieken
b8a8c848c7 qml: enable first wizard page of multisig 2022-11-14 12:19:56 +01:00
Sander van Grieken
5fd8b63091 qml: styling TxDetails 2022-11-14 11:41:33 +01:00
Sander van Grieken
e054e9f14e qml: styling channel details 2022-11-11 17:11:49 +01:00
Sander van Grieken
37b4352c29 qml: some styling fixes 2022-11-11 16:46:24 +01:00
Sander van Grieken
725a05643e qml: channels styling 2022-11-11 16:23:24 +01:00
Sander van Grieken
18131e5a38 qml: styling addresses/address details 2022-11-11 16:00:11 +01:00
Sander van Grieken
ff0f180fab qml: check max comment length for lnurl-pay, characters remaining indicator, styling. 2022-11-11 15:13:39 +01:00
Sander van Grieken
9ce9bb5a4c qml: show request details on receive dialog after adding message/amount 2022-11-11 14:03:43 +01:00
Sander van Grieken
79d12330ac qml: let WalletListModel update the wallet state when a wallet is loaded 2022-11-11 12:28:00 +01:00
Sander van Grieken
12086ba0de qml: unify to single WalletListModel, WalletDB trigger actions on every path set, 
camelcase more QML exposed functions/slots.
 2022-11-11 12:00:07 +01:00
MrNaif2018
b357391c48 Add tx_hashes to exported payment requests (#7936) 
* Add `tx_hashes` to payment requests

* Apply patch

* Fix for missing lnworker
 2022-11-10 17:48:00 +00:00
ghost43
ac239a81b8 Merge pull request #8041 from bigspider/app-bitcoin-new 
Modify Ledger plugin to support the new bitcoin app v2.1.0
 2022-11-10 14:24:14 +00:00
SomberNight
e75110ec04 hw_wallet: de-dupe "message_dialog" code, make text selectable 2022-11-09 21:10:52 +00:00
SomberNight
9b82eb6d06 ledger: re-add support for HW.1, and add a deprecation warning 2022-11-09 20:42:55 +00:00
SomberNight
3cac7e9a61 ledger: minor clean-up 2022-11-09 20:11:08 +00:00
SomberNight
e4a880e435 trezor: use lower device-enumeration timeout for udp transport 
This transport IIUC is only used for the trezor emulator.
The default timeout is 10 seconds. Every time we enumerate hw devices,
we also enumerate trezor devices, including scanning for the udp transport.
For some reason, recently on Windows, sporadically, this scan keeps
hitting the timeout for me. Quite annoying, as I might not even be testing
trezor (and I am certainly not testing using the trezor emulator on Windows...),
but scanning to test other plugins.

Probably overkill to have a 10 sec timeout for contacting localhost anyway.
 2022-11-09 17:46:18 +00:00
Salvatore Ingala
e47270daa5 Fix multiple signing 2022-11-09 13:21:14 +01:00
Salvatore Ingala
3c0e3eb7e2 Refactored LedgerPlugin::create_client, and handle errors when creating the client. 2022-11-09 11:34:41 +01:00
Salvatore Ingala
7c80779903 Replace print() with logger 2022-11-09 11:21:21 +01:00
Salvatore Ingala
80e214d465 - Remove code calling hw1-related features, not supported in the version of btchip embedded in ledger_bitcoin 
- Fix signature of sign_message in Ledger_Client_Legacy
 2022-11-09 10:59:12 +01:00
Salvatore Ingala
f3eb492dca Update Ledger website to ledger.com in error message 2022-11-08 17:44:09 +01:00
Salvatore Ingala
c401f84aa7 Avoid relying on old btchip package; improve missing library error handling 2022-11-08 17:44:06 +01:00
Salvatore Ingala
2d64dc13c9 Modify Ledger plugin to support the new bitcoin app v2.1.0 2022-11-08 17:44:05 +01:00
Pavol Rusnak
b4e5f35e66 trezor: optimize signing speed by not serializing transaction in trezor 
Since Electrum is not using TxRequestSerializedType.serialized_tx
we might ask the device not to serialize transactions
by setting SignTx.serialize=False

This flag is only present in trezorlib 0.13.4, so only users on that
version will benefit from the speedup.

However, we decided to keep the minimum required version to 0.13.0,
since the newer version is not strictly required.
 2022-11-07 16:48:43 +01:00
SomberNight
21dac9f8a6 util.EventListener: don't log "registering callback" 
IMO this is just too spammy to log in the general case when running with -v
 2022-11-06 06:12:41 +00:00
SomberNight
da3b271f5c cosigner_pool plugin: handle multiple multisig wallets open 
fixes https://github.com/spesmilo/electrum/issues/3080
 2022-11-06 04:36:56 +00:00
Sander van Grieken
97f02bca3b qml: add import additional addresses/keys to import wallet 2022-11-04 15:59:27 +01:00
Sander van Grieken
0c9d4abb82 qml: show 2FA status and billing info in WalletDetails, expose billing schedule setting in config 2022-11-04 13:35:15 +01:00
SomberNight
eb2ff94104 android: when running debug apk, disallow changing "enable_debug_logs" 
follow-up 34b594ea40
 2022-11-04 02:40:04 +00:00
SomberNight
84faf7f99a tests: fix TestLNTransport probabilistic failure 
lucky CI run: https://github.com/spesmilo/electrum/runs/9273471816
 2022-11-03 15:45:15 +00:00
SomberNight
21c18bbbe7 util.parse_URI: honour docstring and only raise InvalidBitcoinURI 
follow-up ac1d53f067
 2022-11-03 12:47:21 +00:00
SomberNight
a15e383dbb wallet.add_input_info: also add block_height if known 
The coin_chooser requires the block_height field (to prioritise confirmed utxos).
 2022-11-03 12:30:37 +00:00
ThomasV
015648c4e5 Move get_dict method from wallet_db to json_db. 
Define overloaded methods: _convert_dict _convert_values
 2022-11-03 12:41:49 +01:00
Sander van Grieken
99b2970372 qml: forgot WalletDetails.qml 2022-11-03 12:23:41 +01:00
Sander van Grieken
0649f13ee8 qml: rework drawer, split wallet details from wallet list/picker 2022-11-02 16:43:10 +01:00
Sander van Grieken
3eaebe7b47 qml: flow tags to next line if exceeding most of screen width 
properly update balance amount strings
 2022-11-01 09:42:44 +01:00
Sander van Grieken
3f9df0517a qml: rename walletdetails to walletsummary 2022-11-01 09:40:57 +01:00
Sander van Grieken
00e1d1786c qml: balance piechart in walletdetails, fix menus to top header height 2022-11-01 09:39:20 +01:00
Sander van Grieken
6b979f2185 qml: add basic piechart 2022-10-30 22:51:10 +02:00
Sander van Grieken
7028435daa qml: create wallet details drawer 2022-11-01 09:37:57 +01:00
SomberNight
df2d0f4e1f qt send: use bolt11 fallback addr even if LN is disabled 
Given a wallet with LN disabled,
and a bolt11 invoice (or a bip21 uri that only contains bolt11 but lacks a top-level address),
if the bolt11 invoice includes a fallback address,
we would previously just error "Lightning is disabled".

Now we offer the user to pay on-chain using the fallback address.

closes https://github.com/spesmilo/electrum/issues/8047
 2022-10-31 19:15:03 +00:00
SomberNight
2fd762c308 qt send: bip21: ignore "lightning=" part if LN is disabled 
A wallet with LN disabled could not pay a bip21 URI with an address and a "lightning=" key.
 2022-10-31 19:09:08 +00:00
SomberNight
ac1d53f067 util.parse_URI: allow bip21 with lightning key without fallback addr 
We would reject bip21 URIs that contained both an "address=" and a "lightning=" key with a bolt11 invoice,
where the bolt11 invoice did not contain a fallback address.
 2022-10-31 19:03:12 +00:00
SomberNight
2863fb4ab4 tests: add "as_testnet" fn decorator, to run single tests in testnet 
As opposed to using TestCaseForTestnet class, this allows having a single class
of many related unit tests, some using testnet and some using mainnet constants.
 2022-10-31 18:44:38 +00:00
SomberNight
d3227d7489 transaction: for witness v0 txins, put both UTXO and WIT_UTXO in psbt 
Until now we have been only putting PSBT_IN_NON_WITNESS_UTXO (="UTXO", full tx)
in segwit witness v0 txins, as signers wanted the full tx anyway due to
bip-143 sighash issue [0], and as WITNESS_UTXO can be calculated from UTXO.

My reading of bip-174 is that either behaviour is correct, but
achow101 said bip-174 expects PSBT_IN_WITNESS_UTXO for segwit inputs.
Regardless, including both fields does not increase the tx size too much
(UTXO can be very large ofc but we were already including that, WIT_UTXO is small).
This also might increase compatibility with some other software - I've found
some issues where this might have been the culprit [1][2][3].

closes https://github.com/spesmilo/electrum/issues/8039

related:
[0] https://github.com/spesmilo/electrum/pull/6198
[1] https://github.com/cryptoadvance/specter-desktop/issues/868
[2] https://github.com/cryptoadvance/specter-desktop/issues/1046
[3] https://github.com/cryptoadvance/specter-desktop/issues/1544
 2022-10-31 17:14:21 +00:00