davideandClaude Sonnet 5.5
2b6ddb019b
place_bet and request_withdrawal released everything on any exception from the broadcast, including the 15s timeout and a connection dropped after the write. The tx may have propagated: a bet's sats landed in the pool with no participant, a withdrawal left while its row said failed and its coins were spendable again. - client: ElectrumRpcError (subclass of ElectrumError) is raised only for a reply carrying a JSON-RPC `error`; timeouts, drops and write errors stay plain ElectrumError. - tx/outcome.py:broadcast_with_verdict sorts a broadcast into accepted / refused / uncertain. A refusal is verified first: ElectrumListener.transaction_known asks blockchain.transaction.get of the active server and every other one (10s each) — any server returning the tx means accepted; the active server plus MIN_QUORUM_RESPONSES others all denying it means refused (ALLOW_NO_QUORUM keeps the reduced rule); too few answers is uncertain. "already known" wording is only a shortcut that skips the check. With no network to ask, a refusal is uncertain. - place_bet / request_withdrawal / _trigger_payout use it: only a verified refusal releases; uncertain leaves the rows building for the reconciler, publishes SSE and POST /bets and POST /withdrawals answer 202 with status building; "already known" promotes a payout (payout_sent) like any accepted broadcast. - An accepted transaction is fanned out to every other server (ElectrumListener.fan_out_transaction, best effort, off the caller's path). The RBF replacement in bump_fee is left for B-77, which rewrites that function. Tests changed because the spec changed: the existing "refused broadcast" tests raised a bare RuntimeError (now an uncertain outcome) and are made explicit refusals (rpc_error) with a network that denies the tx; direct route calls pass a Response; FakePayoutListener gains the network surface. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
from fastapi import APIRouter, Depends, Request, Response, status
|
|
from pydantic import BaseModel
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.api.errors import from_api_error, http_error
|
|
from app.auth.dependencies import get_current_user
|
|
from app.db.models import User
|
|
from app.db.session import get_session
|
|
from app.withdrawals.service import WithdrawalError, request_withdrawal
|
|
|
|
router = APIRouter(prefix="/withdrawals", tags=["withdrawals"])
|
|
|
|
|
|
class WithdrawalRequest(BaseModel):
|
|
external_address: str
|
|
amount_sats: int
|
|
|
|
|
|
class WithdrawalResponse(BaseModel):
|
|
txid: str
|
|
amount_requested_sats: int
|
|
amount_sent_sats: int
|
|
status: str
|
|
|
|
|
|
@router.post("", response_model=WithdrawalResponse, status_code=status.HTTP_201_CREATED)
|
|
async def create_withdrawal(
|
|
body: WithdrawalRequest,
|
|
request: Request,
|
|
response: Response,
|
|
user: User = Depends(get_current_user),
|
|
session: AsyncSession = Depends(get_session),
|
|
) -> WithdrawalResponse:
|
|
listener = request.app.state.electrum_listener
|
|
if listener.client is None:
|
|
raise http_error(
|
|
status.HTTP_503_SERVICE_UNAVAILABLE,
|
|
"network_unavailable",
|
|
"not connected to the network, try again shortly",
|
|
)
|
|
|
|
async with request.app.state.user_locks.acquire(user.id):
|
|
try:
|
|
withdrawal = await request_withdrawal(
|
|
session, listener.client, user, body.external_address, body.amount_sats, network=listener
|
|
)
|
|
except WithdrawalError as exc:
|
|
code = (
|
|
status.HTTP_502_BAD_GATEWAY # the network refused it, not the caller (B-07)
|
|
if exc.code == "broadcast_failed"
|
|
else status.HTTP_503_SERVICE_UNAVAILABLE # B-88: write lock not granted, nothing sent
|
|
if exc.code == "service_busy"
|
|
else status.HTTP_400_BAD_REQUEST
|
|
)
|
|
raise from_api_error(code, exc) from exc
|
|
|
|
if withdrawal.status == "building":
|
|
# B-76 (TX-20, WDR-16): uncertain broadcast — accepted for processing, the
|
|
# reconciler decides whether the transaction left.
|
|
response.status_code = status.HTTP_202_ACCEPTED
|
|
return WithdrawalResponse(
|
|
txid=withdrawal.txid,
|
|
amount_requested_sats=withdrawal.amount_requested_sats,
|
|
amount_sent_sats=withdrawal.amount_sent_sats,
|
|
status=withdrawal.status,
|
|
)
|