Commit Graph

16274 Commits

Author SHA1 Message Date
ThomasV 0fcf423fbe Revert "lnworker: schedule_force_closing is not async"
This reverts commit fcf836bc94.
2023-04-22 17:20:47 +02:00
ThomasV fcf836bc94 lnworker: schedule_force_closing is not async 2023-04-22 15:03:39 +02:00
ThomasV f787d6eede qt piechart: show a full circle if there is only one item in the list 2023-04-22 12:50:14 +02:00
Sander van Grieken 0d536b83ba qml: ignore update() when wallet not set yet. closes #8330 2023-04-22 12:18:02 +02:00
Sander van Grieken 7383cdc474 qml: don't crash when tx not found on histogram event. closes #8332 2023-04-22 11:40:36 +02:00
SomberNight 75a9a4fce9 qml TxDetails: txid must be updated after rawtx is changed
refresh bug when using bump_fee/dscancel/etc
2023-04-21 17:39:11 +00:00
SomberNight 2ec4758a12 qml: follow-up fix for offline-signing pre-segwit tx
follow-up 3cec6cdcfb
2023-04-21 17:14:49 +00:00
SomberNight 2be71c2dcc windows README: update reference to libsecp256k1-0.dll to incl newer
related: https://github.com/spesmilo/electrum/pull/8185
2023-04-21 16:38:58 +00:00
SomberNight ca3f48d22e qml: remove buggy "Replace-by-Fee" checkbox from RbfCancelDialog
follow-up 02dce339cc
2023-04-21 15:44:24 +00:00
Sander van Grieken e9d5e5737e qml: update UI after import key/address, add icon to address/key import dialog 2023-04-21 17:05:44 +02:00
Sander van Grieken c3a418d4da qml: address list heading translatable 2023-04-21 17:05:44 +02:00
SomberNight cede16a522 libsecp256k1: update hardcoded .so lib name in binaries
follow-up 2a2b683d23

TODO: maybe we should drop the version number in the lib name we bundle...
2023-04-21 14:42:51 +00:00
Sander van Grieken 2f8ab8027b qml: split off AddressDelegate and handle imported addresses more gracefully 2023-04-21 16:37:39 +02:00
SomberNight ae8501e5be qml: small fix in qetxfinalizer.py
follow-up 3cec6cdcfb
2023-04-21 14:35:37 +00:00
Sander van Grieken bd897b0955 qml: translate <no label> 2023-04-21 16:18:12 +02:00
SomberNight 2a2b683d23 bump libsecp256k1 version 2023-04-21 14:13:32 +00:00
SomberNight 784fc27cb9 libsecp256k1: add runtime support for 0.3.x
this replaces https://github.com/spesmilo/electrum/pull/8320

see https://github.com/bitcoin-core/secp256k1/blob/f6bef03c0a2c826227708dbeaecf1dbc702a2567/CHANGELOG.md

I am not yet sure how this will look like going forward, but unless there will
be lots of libsecp256k1 releases with ~invisible harmless ABI changes, I think
conceptually this is the right approach.
2023-04-21 14:05:21 +00:00
Sander van Grieken 3cec6cdcfb qml: second part of partially signing tx while not having txid yet 2023-04-21 15:09:33 +02:00
Sander van Grieken 03d9000e79 qml: fix a few texts that should wrap 2023-04-21 14:50:08 +02:00
Sander van Grieken b9ec04f13a qml: make txdetails less reliant on txid 2023-04-21 13:20:19 +02:00
SomberNight 75e65c5cc7 qml: virtual keyboard: make margins smaller, for larger buttons
Looking at different system-wide keyboards on different phones, these
new smaller margin sizes should still be sufficient; and this lets
the buttons be larger.
2023-04-20 22:26:45 +00:00
Sander van Grieken 1aa14e749a qml: first part of partially signing tx while not having txid yet 2023-04-21 00:10:15 +02:00
SomberNight 1b5c7d46d7 lnurl: forbid paying to "http://" lnurls (enforce https or .onion)
In theory merchants should only use safeish non-mitm-able schemes, but
let's add this sanity check for peace of mind.
2023-04-20 18:08:42 +00:00
SomberNight 8f576e50a4 lnurl: add some error-handling/response-validation 2023-04-20 17:48:03 +00:00
SomberNight be159b5b95 bugfix: assert walrus (":=") combo side-eff. breaks w/ asserts disabled
```
$ python3 -O
Python 3.10.6 (main, Mar 10 2023, 10:55:28) [GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> assert (x := 2)
>>> x
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'x' is not defined
```

pity. it looked to be a neat and concise pattern.
2023-04-20 15:17:36 +00:00
SomberNight 22205dccb1 qt ChannelsList: disable toolbar menu if not wallet.has_lightning()
closes https://github.com/spesmilo/electrum/issues/8321
2023-04-20 15:06:37 +00:00
SomberNight fa04ff005b contrib: fix build_locale.sh to work with relative paths
I think all scripts that call this file already used abs paths,
but manual callers tend to use relative paths.
2023-04-20 14:57:37 +00:00
SomberNight b0b4f39b40 i18n: add "context" param to _(), and use it from qml
fixes https://github.com/spesmilo/electrum/issues/8323

from issue:
> Currently, translatable strings from QML are assigned a `context`
> by `lupdate`, which is then also used by the conversion to `gettext`.
> This `context` must be used when translating such a string. This results in
> strings that are unique to QML to not be translated, due to a missing
> `context` parameter which we do not take into account in electrum.
2023-04-20 14:31:44 +00:00
Sander van Grieken 1a4e48e2d4 qml: fix MessageDialog layout 2023-04-20 12:07:05 +02:00
Sander van Grieken 54ab3673ba qml: TxDetails don't show or allow edit of label for unrelated tx 2023-04-20 11:02:46 +02:00
Sander van Grieken 3b7fa89e44 wizard: p2sh multisig is 'standard' in backend wallet 2023-04-20 11:00:18 +02:00
Sander van Grieken 323aa84279 qml: only allow wallet menu if on wallet specific page 2023-04-20 10:37:49 +02:00
Sander van Grieken 1649f9993e qml: limit wallet name label widths so they get wrapped/elided. fixes #8317 2023-04-20 10:27:30 +02:00
Emanuel Haupt fd6e34bf5f fix: Fix libsecp256k1 loader on FreeBSD
FreeBSD installs libsecp256k1 as:

```
/usr/local/lib/libsecp256k1.so.2.0.1
/usr/local/lib/libsecp256k1.so -> libsecp256k1.so.2.0.1
/usr/local/lib/libsecp256k1.so.2 -> libsecp256k1.so.2.0.1
```
2023-04-20 09:57:34 +02:00
SomberNight a2063f8f48 qt tx dialog: rm dead code 2023-04-20 00:15:27 +00:00
SomberNight 42ec0e4e9d slip39: fix incorrect type hint 2023-04-19 22:31:08 +00:00
SomberNight cbb4c3ceb2 slip39: rewrite some strings for better localisation
related: https://github.com/spesmilo/electrum/issues/8314
2023-04-19 22:25:02 +00:00
SomberNight dd93ebda4d wallet: _bump_fee_through_decreasing_payment: handle too high fee_rate
fixes https://github.com/spesmilo/electrum/issues/8316
2023-04-19 21:55:07 +00:00
Sander van Grieken 7b475f58db qml: show unrelated tx also in top InfoTextArea 2023-04-19 21:12:31 +02:00
SomberNight 89b75f95d0 wallet.set_broadcasting: fix incorrect type-hint and rename arg 2023-04-19 16:29:54 +00:00
SomberNight e24f837fbf qt send tab: rm incorrect bare raise
follow-up bc3946d2f4

not sure what the raise was trying to do;
note that relevant exception handling is done at:
https://github.com/spesmilo/electrum/blob/bba8a272e78ae8961dffd37060801bf28b934dd9/electrum/gui/qt/main_window.py#L1213-L1217
although note the TODO in main_window.on_error: would be nice to propagate some of the exceptions to the crash reporter

closes https://github.com/spesmilo/electrum/issues/8312
2023-04-19 16:25:39 +00:00
SomberNight bba8a272e7 qt send tab: rm unused variable and add explanation 2023-04-19 16:18:57 +00:00
SomberNight e617dd07a0 qt send tab: fix payto_contacts
closes https://github.com/spesmilo/electrum/issues/8313
2023-04-19 16:08:24 +00:00
ghost43 75578d2baa Merge pull request #8310 from SomberNight/202304_build_debian_apt_rm_contrib
build: rm "contrib" from debian apt sources lists
2023-04-19 12:15:56 +00:00
l-pt f15abd7cbd remove PATH manipulation from .desktop file (#8309)
* remove PATH manipulation from .desktop file

* Add note for user-local intallations
2023-04-19 12:12:18 +00:00
SomberNight 16fcfe34a7 build: rm "contrib" from debian apt sources lists 2023-04-18 16:09:50 +00:00
ThomasV 36db6673a5 update release notes for version 4.4.0 2023-04-18 15:30:31 +02:00
Victor Forgeoux ee61f99c22 Add support for Ledger Stax (#8308)
* Add support for Ledger Stax
2023-04-18 13:11:49 +00:00
ThomasV be2f156a4b qml swaphelper: show errors in userinfo 2023-04-18 15:09:57 +02:00
SomberNight ca40b37ec5 qml: show "tx fee rate" in TxDetails, like in other guis 2023-04-18 12:59:09 +00:00