affe3630b0
qt: addr/coins tab: show tooltip for "freeze address"
...
related https://github.com/spesmilo/electrum/issues/8698
2023-11-24 19:31:36 +00:00
ab9c3bb9b4
qt: avoid potential proxy settings deserialization problems ( fixes #8652 )
2023-11-24 15:06:23 +01:00
6f9e86a1ac
qml: fix wrong year near newyear in transaction list
2023-11-24 10:54:25 +01:00
f602b2bbed
Merge pull request #8700 from SomberNight/202311_apk_build
...
android build: we always want apks, as we want to use our own privkey
2023-11-23 09:42:21 +01:00
f14e99139c
android build: we always want apks, as we want to use our own privkey
...
ThomasV reported contrib/release.sh generating .aab artifacts.
aabs are shady business... best to avoid handing privkeys to big G (or any 3rd party!).
This must be a consequence of the recent p4a rebase,
e.g. https://github.com/kivy/buildozer/commit/04bb63bbf05302a5eb6f24016aa42aadd49c6470
2023-11-23 03:58:35 +00:00
8db68cadcd
swaps: forward swap: make cltv requirements explicit
...
related: fb4eb86e7c
2023-11-22 18:00:32 +00:00
9f1b8613d0
swaps: code style clean-up, add type hints, force kwargs
...
no intended functional changes
2023-11-22 17:50:29 +00:00
9d5d582752
swaps: forward swap: (fix) propagate channels parameter
2023-11-22 16:59:24 +00:00
7f64ecc4bd
wallet.bump_fee: the glorious return of BumpFeeStrategy :D
...
gui/qt/rbf_dialog.py (old) lines 57-64 were implementing logic that should not be part of GUI code.
Case in point, gui/qml/qetxfinalizer.py (old) lines 511-513 duplicated half of that logic but not the other half.
That logic is now moved to wallet.get_bumpfee_strategies_for_tx().
More context: a user on irc got confused when using the qml gui. They were sending "max" and wanted to bump_fee.
The qml gui selected the "preserve_payment" strategy by default, using which there was no solution, and the user
did not notice that the strategy can be altered (via the "method" dropdown). The qt gui had logic to select
"decrease_payment" by default in such a case (which does find a solution to bump) but this logic was not
duplicated in the qml gui.
Instead of duplicating the logic, this commit moves it to shared lib code.
2023-11-20 18:55:43 +00:00
03dd38bfb8
qml: add support for ln address and openalias, fix lnurl finalize step,
...
avoid overloading invoiceParser with new payment identifiers while potentially long-running
resolve/finalize steps are ongoing, show errors inresolve/finalize steps to user.
2023-11-20 17:16:22 +01:00
ff77013a82
qml: check if self._orig_tx is valid. fixes #8407
2023-11-20 17:13:23 +01:00
b098be988e
qml: show channel close tx(id) in ChannelDetails
2023-11-20 12:58:48 +01:00
6a8fb26881
(trivial) follow-up prev
2023-11-20 11:37:39 +00:00
4cdd199f5b
lnworker: add/fix some type hints, add some comments
...
follow-up recent refactor
2023-11-20 11:34:56 +00:00
1cc92d4890
trampoline forwarding: before failing payment, wait until all htcs
...
have failed and session is not longer active.
2023-11-18 16:08:11 +01:00
9b1c40e396
Refactor payment forwarding:
...
- all forwarding types use the same flow
- forwarding callback returns a htlc_key or None
- forwarding info is persisted in lnworker:
- ongoing_forwardings
- downstream to upstream htlc_key
- htlc_key -> error_bytes
2023-11-18 16:03:18 +01:00
f1c63e2d51
commands: make payto/etc respect 'confirmed_only' config var
...
regression from 2f6d60c715https://github.com/spesmilo/electrum/issues/8693
2023-11-17 13:05:23 +00:00
c4068ab6cc
swaps: add small comment
2023-11-17 11:16:45 +00:00
835992c7ea
lnworker: remove if statements where the condition is always True.
...
Such statements creates confusion for the reader.
2023-11-16 17:34:48 +01:00
a57a0d001b
qml: make TextAreas more visible
2023-11-15 18:42:11 +01:00
f8eb2e8cf8
qml: resize menus according to content
2023-11-15 17:35:08 +01:00
4ab973f93d
followup 3793a6b6b6, remove leftovers
2023-11-14 17:22:05 +01:00
3793a6b6b6
qml: use highlight pane for QR codes, refactor ReceiveDialog invoice select UI.
2023-11-14 17:19:27 +01:00
86a45c668c
few small fixes
2023-11-14 14:36:54 +01:00
621a397b70
i18n: translate a few untranslated strings and avoid early translate for pr_tooltips and pr_expiration_values
...
fixes #8689
2023-11-14 12:07:49 +01:00
4006a2f548
SECURITY.md: small clean-up
2023-11-13 15:45:05 +00:00
6ffaf7c526
lnworker: (followup prev) set .config in baseclass init, not subclasses
...
as methods in the base class also rely on the config field, not just methods in the subclasses
2023-11-13 15:39:15 +00:00
7447cf9dcc
lnworker: always initialize self.config in constructor
2023-11-13 14:54:40 +01:00
6865204d7b
Merge pull request #8671 from spesmilo/just_in_time_channels
...
Just in time channels
2023-11-13 14:31:34 +01:00
e5fae1d685
util.NetworkRetryManager: better document API
2023-11-13 12:22:05 +00:00
94b1df4a08
qml: small UI fix, wording.
2023-11-13 11:35:30 +01:00
7bebd62f13
zerofonf trusdted node: use NetworkRetryManager method _can_retry_addr
2023-11-13 10:47:18 +01:00
a338459d45
just-in-time channels:
...
- a node scid alias is derived from the node ID
- the channel opening fee is sent in a TLV field of open_channel
- the server requires htlc settlement before broadcasting
(server does not trust client)
2023-11-13 10:47:18 +01:00
816e617aaf
option_zeroconf
...
- accept zeroconf channels only from a single node
- fw_info uses get_scid_or_local_alias
2023-11-13 10:47:18 +01:00
96e143b6c3
lnpeer: abort send_revoke_and_ack and maybe_send_commitment if channel is closed. fixes #8684
2023-11-13 10:43:16 +01:00
98f9f295cf
fix #8683 ; do not force close channel if we just sent update_fulfill_htlc
2023-11-12 17:10:50 +01:00
4a3a61c6b0
Merge pull request #8678 from accumulator/qml_password_strength
...
qml: introduce PasswordStrengthIndicator control, and add to Password…
2023-11-11 09:52:52 +01:00
d1d4e19554
qml: txdetails: add lockDelay property when height is TX_HEIGHT_FUTURE and add mempool depth for height TX_HEIGHT_UNCONF_PARENT
2023-11-10 17:03:56 +01:00
de0dc93a9d
Merge pull request #8675 from accumulator/address_delete
...
qml: implement delete address for imported wallets
2023-11-10 15:23:29 +01:00
4252c30210
Merge pull request #8682 from accumulator/about_version
...
qml: remove APK version, add Qt and PyQt version strings to About page
2023-11-10 15:04:53 +01:00
3967323842
qml: refactor ChannelDetails. Add funding outpoint
2023-11-10 13:02:55 +01:00
2995bc8b37
qml: fix dialog not closing if dialog is shown/hidden more than once
...
most dialogs are destroyed when closed, therefore not hitting this bug,
but e.g. ChannelOpenProgressDialog is reused.
2023-11-10 11:59:22 +01:00
42f323ac8d
qml: remove APK version, add Qt and PyQt version strings to About page
2023-11-10 11:11:51 +01:00
0fb47c87d2
qml: fixes for CloseChannelDialog;
...
- split RequestForceClose and LocalForceClose options, as request force close is only available if connected.
- disable no close policy on dialog, as it locks the user in the dialog if no succesful close is initiated.
what this intended to do is keep the backing object QEChannelDetails alive until a result is obtained, to avoid
exceptions when emitting the result signal. this is now handled more robustly, the user can leave the dialog
without triggering exceptions later.
2023-11-10 10:58:08 +01:00
fb4eb86e7c
submarine swaps: remove support for 'old' normal swaps,
...
where the user has the preimage.
The CLTV requirements between old and new flow are imcompatible.
With the current locktime value, the server was vulnerable to an
attack where the client does not settle the lightning payment
and claims a refund. In order to support both old and new flows,
one would need to use different locktimes.
2023-11-10 10:35:34 +01:00
300c3bbd30
submarine_swaps: rename variable for clarity
2023-11-10 10:05:04 +01:00
e011bd235b
qml: implement delete address for imported wallets, and fix address list on address/key add.
2023-11-10 09:30:56 +01:00
98264f64ad
qml: introduce PasswordStrengthIndicator control, and add to PasswordDialog and WCWalletPassword
2023-11-10 09:30:31 +01:00
d49e1bb32c
contrib/android/Readme.md: update "how to run qml gui on linux" section
2023-11-09 16:40:45 +00:00
5ba156fcad
Merge remote-tracking branch 'remotes/accumulator/qt6'
...
For the "qml" gui (used on Android), this upgrades the qt version from 5.15 to 6.4.
PR https://github.com/spesmilo/electrum/pull/8545
2023-11-09 16:18:56 +00:00
SomberNight