Commit Graph

13091 Commits

Author SHA1 Message Date
ThomasV da2c8a3c05 Merge pull request #6795 from bitromortac/fix-6770
[wip] swaps: fix infinite recursion for max button
2020-12-04 11:03:30 +01:00
bitromortac 08698ad607 swaps: fix infinite recursion for max button 2020-12-04 10:22:42 +01:00
ThomasV 3f9d7d8b33 kivy: save password after wallet creation
Previously, operations that require password
would fail until the wallet is reopened
2020-12-03 10:36:45 +01:00
ThomasV 7ce4727507 kivy wizard: do call run() when password dialog is dismissed, it modifies the stack. (see #6582) 2020-12-02 11:23:03 +01:00
ThomasV 2923c00d38 kivy: do not use an event to call on_wizard_complete, initialize self.app in constructor 2020-12-01 13:18:04 +01:00
ThomasV f187587430 rm dead code: first branch of the if never evaluated because WalletDB is called with manual_upgrades=False 2020-12-01 10:25:47 +01:00
ThomasV 4640bf7fcb kivy: remove dead code (installwizard waiting_dialog) 2020-12-01 09:13:20 +01:00
ThomasV 3d2736b014 add debug option to avoid retyping the seed in kivy 2020-11-30 14:37:32 +01:00
ThomasV d3b34263cd kivy: storage is already decrypted in on_open_wallet 2020-11-30 14:16:13 +01:00
ThomasV fad3bd724c kivy: remove unused keyboard binding 2020-11-30 12:20:03 +01:00
ThomasV 286df92ba9 kivy: cleanup unused code 2020-11-30 11:07:54 +01:00
ThomasV a9fc440775 fix #6351: set screen attribute right after screen is loaded 2020-11-30 11:06:32 +01:00
ThomasV 427779350f Trustedcoin: call wizard.terminate with aborted set to True in various failure conditions (see #4496) 2020-11-29 11:43:33 +01:00
ThomasV c46fbf08a5 Qt installwizard: raise UserCancelled if user clicks cancel (the wizard was hanging instead of terminating) 2020-11-29 09:27:00 +01:00
ThomasV 915e132c33 fix 'max' button in Kivy (fix #6169) 2020-11-27 12:48:32 +01:00
ThomasV 9e1c4a59e5 Merge pull request #6787 from bitromortac/fix-6781
lnrater: fix KeyError for unknown node
2020-11-27 09:50:43 +01:00
bitromortac 793f2569a7 lnrater: fix KeyError for unknown node 2020-11-26 20:01:05 +01:00
ThomasV 2638c818e9 fix #6757: truncate invoice description to 639 bytes 2020-11-26 12:07:03 +01:00
ThomasV 2904615211 kivy: do not display internal id of onchain invoice, show address instead 2020-11-26 09:08:20 +01:00
ThomasV 8e2320552f Merge pull request #6754 from nc50lc/master
Fix Import/Export contacts issue
2020-11-25 11:51:17 +01:00
ThomasV 43c5df2ab5 Setconfig: set rpc_user rpc_password in daemon (fix #6762).
Do not disable auth if password is an empty string.
2020-11-25 11:47:30 +01:00
SomberNight 7e18e2ea31 qt main_window: (trivial) fix error-handling for open_channel
fixes #6776
2020-11-25 10:03:49 +01:00
ThomasV 4ae2717ac7 lnworker: better indentation (refactoring only) 2020-11-25 09:16:40 +01:00
SomberNight f0cca25303 wallet: fix dscancel for "not all inputs ismine" case
fixes #6693
2020-11-25 09:00:44 +01:00
ThomasV 1161ce919f Move get_channel_info and get_channel_policy code, so that routing
hints can be created without access to a ChannelDB instance.
2020-11-25 08:53:19 +01:00
SomberNight 4bd4fc7697 qt send tab: (regression) fix handling multiline fmt for single line
fixes #6761
2020-11-25 00:03:38 +01:00
SomberNight 01fe443928 lnrouter: nicer repr for PathEdge and RouteEdge 2020-11-24 23:44:09 +01:00
SomberNight 18066c72a0 lnaddr: fix decoding of min_final_cltv_expiry
Previously we failed to decode min_final_cltv_expiry properly if the highest bit was 1:
in practice, we could not pay invoices that had a value in [16-31] or [512-1023].
Many invoices use a value around 144, so this was simply unnoticed.

also update default value to follow BOLT change:
https://github.com/lightningnetwork/lightning-rfc/commit/c5693d336d5e166e8e5bfce45f081bc61c0e7999
2020-11-24 23:42:29 +01:00
ghost43 1bf8d2ea56 Merge pull request #6766 from benma/bb02
bitbox02: more robust account keypath
2020-11-24 20:42:22 +00:00
Jin Eguchi eaacecf4a1 Fix get_running_loop (python<3.7) (#6765) 2020-11-24 20:39:30 +00:00
Benoît Verret a1c02e2c45 Fix daemon being treated as a function (#6771)
daemon was improperly turned into a function in the Python console.
Point daemon to window.gui_object.daemon instead.
2020-11-24 20:24:44 +00:00
ThomasV 85bce256e7 Merge pull request #6758 from Emzy/patch-1
add mempool.emzy.de explorer
2020-11-23 15:08:36 +01:00
Marko Bencun b78b077606 bitbox02: more robust account keypath
In multisig, we plan to allow other kinds of keypaths that are not
exactly 4 elements long. This change allows parsing the account
keypath for any kind of keypath, assuming the last two element are /change/address.
2020-11-23 14:32:04 +01:00
Stephan Oeste a5acb7d695 add mempool.emzy.de
Same software as mempool.space other operator.
2020-11-22 01:43:47 +01:00
SomberNight 9fced6d2b1 qt send tab: "max" btn should not raise NotEnoughFunds due to fees
If a tx cannot be constructed due to current fee settings, try to
create one with zero miner fees instead and let user to change the
fee later.

fixes #6755
2020-11-21 19:35:27 +01:00
SomberNight 756d2eb004 mac build: call git describe after git submodule update
otherwise it could be that `git describe` will say "dirty" but the binary
will not actually be dirty as it just needed `git submodule update`
2020-11-21 19:29:29 +01:00
ThomasV 32ffc9e9a4 convert Qt flags to int (fix Qt DeprecationWarning) 2020-11-21 12:15:24 +01:00
nc50lc 33da994131 Update contact_list.py
Try to fix https://github.com/spesmilo/electrum/issues/6356
2020-11-21 12:30:57 +08:00
ThomasV dfcdcb8d64 fix typo 2020-11-20 08:51:01 +01:00
ThomasV 0b183444b4 Rename maybe_init_lightning(). Call load_data() from there 2020-11-20 08:35:57 +01:00
SomberNight 13563697f5 exchange_rate: log full traceback in case of unexpected exception
related: #6748
2020-11-20 01:45:11 +01:00
SomberNight 57768244bb qt history list: fix #6746 2020-11-18 23:50:08 +01:00
SomberNight 6f105ae43b android build: bump targetSdkVersion to 29 (follow-up)
follow-up: 59e9337be0

For some reason, without this change, the first build works but subsequent builds fail.
Not sure what the cause is. This is why Travis builds work.
2020-11-18 20:22:13 +01:00
SomberNight 827f00896c update locale submodule 2020-11-18 20:19:38 +01:00
SomberNight 5c0430dced prepare release 4.0.5 2020-11-18 19:43:24 +01:00
SomberNight 16a326cdd3 qt receive tab: rename "create onchain" btn to "New Address" 2020-11-18 18:58:37 +01:00
SomberNight 3f04520d0f ledger: suppress traceback during device enumeration for locked device
ledger now gives an error if querying xpub while device is not (unlocked and in bitcoin app).
we do query the xpub however, to calc root fingerprint to be used as soft device id.

trace:

I | plugin.DeviceMgr | scanning devices...
D | util.profiler | DeviceMgr.scan_devices 3.4463
I | plugin.DeviceMgr | Registering <electrum.plugins.ledger.ledger.Ledger_Client object at 0x0000029DF6B08520>
E | gui.qt.installwizard.InstallWizard |
Traceback (most recent call last):
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 225, in checkDevice
    self.perform_hw1_preflight()
  File "...\electrum\electrum\plugin.py", line 362, in wrapper
    return run_in_hwd_thread(partial(func, *args, **kwargs))
  File "...\electrum\electrum\plugin.py", line 352, in run_in_hwd_thread
    return func()
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 219, in perform_hw1_preflight
    raise e
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 179, in perform_hw1_preflight
    firmwareInfo = self.dongleObject.getFirmwareVersion()
  File "...\Python38\site-packages\btchip\btchip.py", line 563, in getFirmwareVersion
    response = self.dongle.exchange(bytearray(apdu))
  File "...\Python38\site-packages\btchip\btchipComm.py", line 127, in exchange
    raise BTChipException("Invalid status %04x" % sw, sw)
btchip.btchipException.BTChipException: Exception : Invalid status 6700

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "...\electrum\electrum\base_wizard.py", line 317, in _choose_hw_device
    device_infos = devmgr.unpaired_device_infos(None, plugin, devices=scanned_devices,
  File "...\electrum\electrum\plugin.py", line 612, in unpaired_device_infos
    soft_device_id=client.get_soft_device_id(),
  File "...\electrum\electrum\plugin.py", line 362, in wrapper
    return run_in_hwd_thread(partial(func, *args, **kwargs))
  File "...\electrum\electrum\plugin.py", line 355, in run_in_hwd_thread
    return fut.result()
  File "...\Python38\lib\concurrent\futures\_base.py", line 439, in result
    return self.__get_result()
  File "...\Python38\lib\concurrent\futures\_base.py", line 388, in __get_result
    raise self._exception
  File "...\Python38\lib\concurrent\futures\thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 91, in get_soft_device_id
    self._soft_device_id = self.request_root_fingerprint_from_device()
  File "...\electrum\electrum\plugin.py", line 362, in wrapper
    return run_in_hwd_thread(partial(func, *args, **kwargs))
  File "...\electrum\electrum\plugin.py", line 352, in run_in_hwd_thread
    return func()
  File "...\electrum\electrum\plugins\hw_wallet\plugin.py", line 259, in request_root_fingerprint_from_device
    child_of_root_xpub = self.get_xpub("m/0'", xtype='standard')
  File "...\electrum\electrum\plugin.py", line 362, in wrapper
    return run_in_hwd_thread(partial(func, *args, **kwargs))
  File "...\electrum\electrum\plugin.py", line 352, in run_in_hwd_thread
    return func()
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 57, in catch_exception
    return func(self, *args, **kwargs)
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 111, in get_xpub
    self.checkDevice()
  File "...\electrum\electrum\plugin.py", line 362, in wrapper
    return run_in_hwd_thread(partial(func, *args, **kwargs))
  File "...\electrum\electrum\plugin.py", line 352, in run_in_hwd_thread
    return func()
  File "...\electrum\electrum\plugins\ledger\ledger.py", line 228, in checkDevice
    raise UserFacingException(_("Device not in Bitcoin mode")) from e
electrum.util.UserFacingException: Device not in Bitcoin mode
W | gui.qt.installwizard.InstallWizard | error getting device infos for ledger: Device not in Bitcoin mode
2020-11-18 15:36:15 +01:00
SomberNight b78cbcffd1 ledger: fix enumerating ledger devices with new bitcoin app (1.5.1)
see https://github.com/bitcoin-core/HWI/issues/402
2020-11-18 15:36:11 +01:00
ThomasV aaff48720f Qt lightning invoice dialog: make payment_hash copiable 2020-11-18 11:47:47 +01:00
SomberNight f3c1313a4f coldcard: avoid creating keystore with testnet/mainnet mixed up
fixes #6722
2020-11-18 00:47:20 +01:00